Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/podaac 6169: Regression tests #74

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Feature/podaac 6169: Regression tests #74

merged 3 commits into from
Apr 24, 2024

Conversation

yenes56
Copy link
Contributor

@yenes56 yenes56 commented Apr 17, 2024 •
edited
Loading

Ticket: [PODAAC-6169]

Description

  • PODAAC-6169
    • SWOT iso.xml
    • OPERA iso.xml
    • SWOT archive.xml
    • .mp
    • SWOT CalVal XML
    • Does/does not cross the IDL

Overview of work done

upgrade libraries to pass snyk vulnerability check
pre-saved the generated UMMG for unit test cases listed above.
add code to compare generated UMMG against the saved UMMG

In order to make both

  • mvn test
    and
  • graldle test

run (both of them execute through each test file in a single thread with sequential mode). it is necessary to change how we use Mokito mock. The details are within the newly added @before and @after annotated functions within UMMTest and MetadataFilesToEchoTest.java.

Overview of verification done

  • run unit tests and all passed

Tested in SIT:

Explain how you tested in SIT, if applicable

PR checklist:

  • Linted
  • Unit tests
  • Addressed Snyk vulnerabilities
  • Updated changelog
  • Tested in SIT
  • [] Documentation / User-Guide Updated

See Pull Request Review Checklist for pointers on reviewing this pull request

@yenes56 yenes56 closed this Apr 18, 2024
@yenes56 yenes56 reopened this Apr 20, 2024
hkryeung
hkryeung approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@hkryeung hkryeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed tests run and all pass! GJ

@skorper skorper changed the title Feature/podaac 6169 Feature/podaac 6169: Regression tests Apr 23, 2024
skorper
skorper approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@skorper skorper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @yenes56! This is going to make refactoring much easier. Thank you!

@skorper skorper marked this pull request as draft April 23, 2024 23:45
@skorper skorper marked this pull request as ready for review April 23, 2024 23:52
@skorper
Copy link
Contributor

skorper commented Apr 23, 2024 •
edited
Loading

@yenes56 Can you please move the changelog entry to a new "unreleased" section?

@yenes56 yenes56 merged commit b9aaddd into develop Apr 24, 2024
3 checks passed
@yenes56 yenes56 deleted the feature/PODAAC-6169 branch May 1, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skorper skorper skorper approved these changes

@hkryeung hkryeung hkryeung approved these changes

Assignees

@skorper skorper

@hkryeung hkryeung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yenes56 @skorper @hkryeung